Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header/core: Put Blocks into the eds.Store in Listener #1423

Closed
Tracked by #1099
Wondertan opened this issue Dec 1, 2022 · 1 comment
Closed
Tracked by #1099

header/core: Put Blocks into the eds.Store in Listener #1423

Wondertan opened this issue Dec 1, 2022 · 1 comment
Assignees
Labels
area:block Raw blocks and erasure coded blocks area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Dec 1, 2022

Context

Right now, the Listener stores the block data into ipfs.Blockservice during ExtendedHeader and EDS construction. As per #1099, we are now migrating to new storage for blocks - eds.Store and Listener should store the EDS/Block there.

This will likely require changes to the header.MakeExtendedHeader and likely simplify it by removing dependency on ipfs.Blockservice

@Wondertan Wondertan changed the title core: Put Blocks into the eds.Store in Listener header/core: Put Blocks into the eds.Store in Listener Dec 1, 2022
@renaynay renaynay added area:shares Shares and samples area:block Raw blocks and erasure coded blocks and removed needs:triage labels Dec 5, 2022
renaynay added a commit that referenced this issue Jan 24, 2023
…e header root package (#1627)

This PR is a blocker to #1423 

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
distractedm1nd pushed a commit to distractedm1nd/celestia-node that referenced this issue Jan 26, 2023
…e header root package (celestiaorg#1627)

This PR is a blocker to celestiaorg#1423 

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
walldiss pushed a commit to walldiss/celestia-node that referenced this issue Jan 26, 2023
…e header root package (celestiaorg#1627)

This PR is a blocker to celestiaorg#1423 

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
renaynay added a commit to renaynay/celestia-node that referenced this issue Jan 31, 2023
…e header root package (celestiaorg#1627)

This PR is a blocker to celestiaorg#1423 

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
renaynay added a commit that referenced this issue Feb 1, 2023
…e header root package (#1627)

This PR is a blocker to #1423

It extracts `CoreExchange` and `CoreListener` from the header package
into the core package and moves header testing utilities into a separate
package at the root level called `headertest`.
@renaynay
Copy link
Member

renaynay commented Mar 6, 2023

Completed as part of ShrEx implementation

@renaynay renaynay closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:block Raw blocks and erasure coded blocks area:shares Shares and samples
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants