Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestMaxTotalBlobSizeSuite fails test-race #2276

Closed
rootulp opened this issue Aug 15, 2023 · 0 comments · Fixed by #2277
Closed

TestMaxTotalBlobSizeSuite fails test-race #2276

rootulp opened this issue Aug 15, 2023 · 0 comments · Fixed by #2277
Assignees
@rootulp
Labels
bug Something isn't working testing items that are strictly related to adding or extending test coverage

Comments

@rootulp
Copy link
Collaborator

rootulp commented Aug 15, 2023

Problem

TestMaxTotalBlobSizeSuite fails test-race here

Proposal

  1. Add the test to

    celestia-app/Makefile

    Line 161 in 35c4b0e

    @go test -mod=readonly ./... -v -race -skip "TestPrepareProposalConsistency|TestIntegrationTestSuite|TestQGBRPCQueries|TestSquareSizeIntegrationTest|TestStandardSDKIntegrationTestSuite|TestTxsimCommandFlags|TestTxsimCommandEnvVar|TestMintIntegrationTestSuite|TestQGBCLI|TestUpgrade|TestMaliciousTestNode|TestVestingModule"
  2. All the tests that use testnode fail test-race. Tracked in Investigate the tests race conditions #1369
@rootulp rootulp added bug Something isn't working testing items that are strictly related to adding or extending test coverage labels Aug 15, 2023
@rootulp rootulp self-assigned this Aug 15, 2023
@github-actions github-actions bot added the bot item was created by a bot label Aug 15, 2023
This was referenced Aug 15, 2023
Merged
Merged
@rootulp rootulp removed the bot item was created by a bot label Aug 16, 2023
rootulp added a commit that referenced this issue Aug 16, 2023
@rootulp
test: skip TestMaxTotalBlobSizeSuite during test-race (#2277)
101390d 
Closes #2276
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
test: skip TestMaxTotalBlobSizeSuite during test-race (#2277)
7ebd6c1 
Closes celestiaorg/celestia-app#2276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
bug Something isn't working testing items that are strictly related to adding or extending test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: skip TestMaxTotalBlobSizeSuite during test-race rootulp/celestia-app
1 participant
@rootulp