Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing block height check in PrepareProposal for improved behavior #2221

Closed
Tracked by #2256
staheri14 opened this issue Aug 8, 2023 · 0 comments · Fixed by #2233
Closed
Tracked by #2256

Implementing block height check in PrepareProposal for improved behavior #2221

staheri14 opened this issue Aug 8, 2023 · 0 comments · Fixed by #2233
Assignees
@staheri14
Labels
enhancement New feature or request

Comments

@staheri14
Copy link
Contributor

The following suggestion is related to #1899, and is originally suggested by @evan-forbes in this comment

we don't have to handle it all in this PR, but after we add the hacky if statement protection in PrepareProposal, we could also add a different test that waits for block height 2 and then ensures that the first block is empty
@staheri14 staheri14 self-assigned this Aug 8, 2023
@staheri14 staheri14 added the enhancement New feature or request label Aug 8, 2023
@staheri14 staheri14 added this to the Mainnet milestone Aug 8, 2023
This was referenced Aug 8, 2023
Merged
Closed
Merged
@evan-forbes evan-forbes mentioned this issue Aug 11, 2023
Closed
7 tasks
@staheri14 staheri14 mentioned this issue Aug 14, 2023
Closed
staheri14 added a commit that referenced this issue Aug 15, 2023
@staheri14
feat: implements block height check in PrepareProposal to avoid unexp…
e2b154d 
…ected errors at height 1 (#2233)

## Overview
Closes #1899 
Closes #2221

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
mergify bot pushed a commit that referenced this issue Sep 5, 2023
@staheri14 @mergify
feat: implements block height check in PrepareProposal to avoid unexp…
3b37af0 
…ected errors at height 1 (#2233)

## Overview
Closes #1899
Closes #2221

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

(cherry picked from commit e2b154d)

# Conflicts:
#	app/test/block_production_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@staheri14