Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown lint CI not failing on non-respected rules #2212

Closed
rach-id opened this issue Aug 4, 2023 · 0 comments · Fixed by celestiaorg/.github#69 or #3200
Closed

Markdown lint CI not failing on non-respected rules #2212

rach-id opened this issue Aug 4, 2023 · 0 comments · Fixed by celestiaorg/.github#69 or #3200
Labels
bug Something isn't working CI item that directly relates to or modify the CI

Comments

@rach-id
Copy link
Member

rach-id commented Aug 4, 2023

As perceived in #2211 and #2209 (review), markdown lint CI is not failing on the non-respected rules. We need to investigate that.
@rach-id rach-id added bug Something isn't working CI item that directly relates to or modify the CI labels Aug 4, 2023
@rach-id rach-id mentioned this issue Aug 4, 2023
Merged
5 tasks
rootulp added a commit to celestiaorg/.github that referenced this issue Aug 4, 2023
@rootulp
chore: upgrade to markdownlint-cli v0.35.0
b6815fc 
Attempt to resolve celestiaorg/celestia-app#2212

Ref: https://github.com/igorshubovych/markdownlint-cli/releases/tag/v0.35.0
@rootulp rootulp mentioned this issue Aug 4, 2023
Merged
@rach-id rach-id reopened this Aug 4, 2023
@rootulp rootulp mentioned this issue Aug 8, 2023
Closed
@rootulp rootulp mentioned this issue Mar 20, 2024
Merged
rootulp added a commit that referenced this issue Mar 20, 2024
@rootulp
chore: upgrade to markdownlint v0.39.0 (#3200)
e3e11e2 
Maybe closes #2212

## Motivation


#3198 (comment)
ninabarbakadze pushed a commit to ninabarbakadze/celestia-app that referenced this issue Apr 2, 2024
@rootulp @ninabarbakadze
chore: upgrade to markdownlint v0.39.0 (celestiaorg#3200)
d76ce34 
Maybe closes celestiaorg#2212

## Motivation


celestiaorg#3198 (comment)
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
chore: upgrade to markdownlint v0.39.0 (#3200)
c92825a 
Maybe closes celestiaorg/celestia-app#2212

## Motivation


celestiaorg/celestia-app#3198 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI item that directly relates to or modify the CI
Projects
None yet
Milestone
No milestone
1 participant
@rach-id