Usage of ShareVersionZero for building padding shares instead blob.sharesversion

[andrijamitrovic23]

Builder for building padding shares is created using ShareVersionZero share version. This happens within function NamespacePaddingShare that is called from Export function when building padding shares (WriteNamespacePaddingShares->NamespacePaddingShares->NamespacePaddingShare->NewBuilder).

It can be seen that the non padding shares within Export function are created ((Write->NewBuilder(blobNamespace, blob.ShareVersion, true).Init())) with shares Builder that takes blob.ShareVersion.

At the time being, when there is only ShareVersionZero share version, this is not a problem, but when new share versions are introduced it could happen that the padding is created with different share version then the preceding shares which could lead to inconsistency. Passing blob.ShareVersion to NamespacePaddingShare and using it in the NewBuilder constructor should prevent this from happening.

[rootulp]

Great catch!