docker: Prettify comment sections in Dockerfile and Dockerfile.ephemeral. #2117
Assignees
Labels
good first issue
Good for newcomers
ice-box
this label is automatically applied to all issues. it is removed after starting work
Comments
evan-forbes
added
the
ice-box
|
There is no longer Dockerfile.ephemeral but there are two Dockerfiles that could use improved comments:
The Dockerfile for testground seem really helpful and could be used for inspiration. |
|
Honestly going to ignore the txsim Dockerfile for now b/c it's not as important as the other one. |
rootulp
added a commit
that referenced
this issue
Mar 11, 2024
Closes #2117 I can think of a few follow-ups after reviewing this Dockerfile: 1. Can we use a different username than `celestia`? Perhaps `celestia-app` to avoid any user name collision with celestia-node. 2. Does `$BUILDPLATFORM` actually get populated? 3. Can we get rid of the hadolint ignore by pinning versions for all the dependencies? 4. Bump the Alpine version for the BUILDER image 5. `make hadolint` only runs on Dockerfile and not the other Dockerfiles in this repo cc: @Bidon15 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
ninabarbakadze
pushed a commit
to ninabarbakadze/celestia-app
that referenced
this issue
Mar 13, 2024
Closes celestiaorg#2117 I can think of a few follow-ups after reviewing this Dockerfile: 1. Can we use a different username than `celestia`? Perhaps `celestia-app` to avoid any user name collision with celestia-node. 2. Does `$BUILDPLATFORM` actually get populated? 3. Can we get rid of the hadolint ignore by pinning versions for all the dependencies? 4. Bump the Alpine version for the BUILDER image 5. `make hadolint` only runs on Dockerfile and not the other Dockerfiles in this repo cc: @Bidon15 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
ninabarbakadze
pushed a commit
to ninabarbakadze/celestia-app
that referenced
this issue
Apr 2, 2024
Closes celestiaorg#2117 I can think of a few follow-ups after reviewing this Dockerfile: 1. Can we use a different username than `celestia`? Perhaps `celestia-app` to avoid any user name collision with celestia-node. 2. Does `$BUILDPLATFORM` actually get populated? 3. Can we get rid of the hadolint ignore by pinning versions for all the dependencies? 4. Bump the Alpine version for the BUILDER image 5. `make hadolint` only runs on Dockerfile and not the other Dockerfiles in this repo cc: @Bidon15 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this issue
Aug 1, 2024
Closes celestiaorg/celestia-app#2117 I can think of a few follow-ups after reviewing this Dockerfile: 1. Can we use a different username than `celestia`? Perhaps `celestia-app` to avoid any user name collision with celestia-node. 2. Does `$BUILDPLATFORM` actually get populated? 3. Can we get rid of the hadolint ignore by pinning versions for all the dependencies? 4. Bump the Alpine version for the BUILDER image 5. `make hadolint` only runs on Dockerfile and not the other Dockerfiles in this repo cc: @Bidon15 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I guess a follow-up PR will fix other Dockerfiles.
Editing this one, tho
Originally posted by @Bidon15 in #2052 (comment)
Tasks
The text was updated successfully, but these errors were encountered: