Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite alarms do not adhere to disambiguator #364

Open
openwebsolns opened this issue May 9, 2023 · 0 comments
Open

Composite alarms do not adhere to disambiguator #364

openwebsolns opened this issue May 9, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@openwebsolns
Copy link

Version

3.1.2

Steps and/or minimal code example to reproduce

Consider the MonitoringFacade below with default action and disambiguator action:

monitor = new MonitoringFacade(this, "Monitor", {
  ...props,
  alarmDefaults: {
    action: defaultAction(),
    disambiguatorAction: {
      Critical: criticalAction(),
    },
  },
});

monitor.createCompositeAlarmUsingTag(ROLLBACK_TAG, {
  disambiguator: "Critical",
});

Expected behavior

The composite alarm created should be using criticalAction().

Actual behavior

The composite alarm created is using defaultAction()

Other details

The 🐛 appears to be the way action is calculated:

@openwebsolns openwebsolns added the bug Something isn't working label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant