Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust packages broken by wrong digests #235

Closed
OmarTawfik opened this issue Nov 13, 2022 · 4 comments
Closed

rust packages broken by wrong digests #235

OmarTawfik opened this issue Nov 13, 2022 · 4 comments

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Nov 13, 2022

Several (all?) Rust projects are now suddenly broken with the following error:

fatal:hermit: https://static.rust-lang.org/dist/rust-1.64.0-x86_64-unknown-linux-gnu.tar.xz: https://static.rust-lang.org/dist/rust-1.64.0-x86_64-unknown-linux-gnu.tar.xz: checksum bd69e42f6cfe3ba96d781ad0b4095ddac4f0fc31c1af445018edf6f0aba543e4 should have been b51d1e2f752f58d02d781566f3e3ac4da0a666896ebba49d70f404dbaf312d7c

I traced the issue to 900d521 (cc @alecthomas). I think there is a bug in whichever import script it is using, which made it put the same digest in rust.hcl, for both apple-darwin.tar.xz and unknown-linux-gnu.tar.xz, for all versions.

To unblock these projects, I tried locking the hermit-packages source version, which failed as well. I filed a separate bug for: cashapp/hermit#342

So, for now, I manually forked rust.hcl (as a private package) to unblock these projects.

@alecthomas
Copy link
Collaborator

Ah I missed "all versions". Interesting 🤔

@alecthomas
Copy link
Collaborator

Ah I see what happened, I forgot to add the arch interpolation to the sha256-sources entry when I generated these digests:

// sha256-source = "https://static.rust-lang.org/dist/rust-${version}-${xarch}-apple-darwin.tar.xz.sha256"

alecthomas added a commit that referenced this issue Nov 13, 2022
@OmarTawfik
Copy link
Contributor Author

Thank you!

@alecthomas
Copy link
Collaborator

Thanks for the report, and apologies for the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants