Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded transitive dependencies can cause lockfile to be in a bad state #105

Open
dellisd opened this issue Sep 29, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@dellisd
Copy link
Collaborator

dellisd commented Sep 29, 2023

  1. Imagine both the base and feature modules transitively depend on Guava.
  2. In the base module, some dependency excludes some of Guava's transitive dependencies.
  3. The feature module depends on a newer version of Guava
  4. When the lockfile is merged, this plugin will take the newer of the two versions from the feature module including its whole transitive dependency subtree
  5. This will pull in Guava's transitive deps that were excluded from the base module
  6. This puts the lockfile in a bad state because it will include transitive deps that will not be resolved in the base module.
@dellisd dellisd added the bug Something isn't working label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant