Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3beta1 allows numbers as short as 4 characters as valid #72

Open
calebanderson opened this issue Aug 24, 2015 · 0 comments
Open

1.3beta1 allows numbers as short as 4 characters as valid #72

calebanderson opened this issue Aug 24, 2015 · 0 comments

Comments

@calebanderson
Copy link

With a default country code set '1111' is seen as valid because of this line:
https://github.com/carr/phone/blob/master/lib/phone.rb#L152

And the fact that the only validation around 'number' is that it's 1-8 characters long. This used to be caught because format :really_short would be automatically selected and would try to prepend the area code to the beginning and fail if it was not given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant