Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows 9&11 digit North American phone numbers #25

Open
jpaas opened this issue May 16, 2012 · 2 comments
Open

Allows 9&11 digit North American phone numbers #25

jpaas opened this issue May 16, 2012 · 2 comments

Comments

@jpaas
Copy link

jpaas commented May 16, 2012

Maybe I'm just not aware that these are valid, but the gem is allowing North American phone numbers with 9 and 11 digits. As far as I know only 10 digits are valid.

e.g.

ruby-1.9.2-p290 :017 > Phoner::Phone.parse "212-555-121", :country_code => '1'
=> +1212555121
ruby-1.9.2-p290 :018 > Phoner::Phone.parse "212-555-12", :country_code => '1'
RuntimeError: Must enter area code or set default area code
ruby-1.9.2-p290 :019 > Phoner::Phone.parse "212-555-12", :country_code => '1', :area_code => '666'
=> +166621255512

@g1smd
Copy link

g1smd commented Nov 12, 2012

The repo owner is AWOL. Your issue has already been ignored for 6 months.

Try the wmoxam/phone branch instead. The code there is much more actively maintained.

@elskwid
Copy link
Collaborator

elskwid commented May 9, 2013

I'm going to be making a pass through issues soon. See #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants