Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra CR needed #88

Open
nixilb opened this issue Feb 11, 2021 · 2 comments
Open

Extra CR needed #88

nixilb opened this issue Feb 11, 2021 · 2 comments

Comments

@nixilb
Copy link

nixilb commented Feb 11, 2021

There is a extra CR needed at this step that makes people wait "forever"
Capture

@baileyherbert
Copy link

baileyherbert commented Nov 2, 2021

After some debugging, this seems to be a bug in the inquirer package (or possibly readline itself) when you use an asynchronous when that returns false, like caprover does here:

when: async () => {

The above option is used from the deploy command at the following line:

CliHelper.get().getEnsureAuthenticationOption(

I was able to reproduce in my own project with the latest inquirer version. I'll do more debugging and possibly open an issue there (edit: issue at SBoudrias/Inquirer.js#1062)

@emirefek
Copy link

emirefek commented Aug 3, 2022

Why this very small bug still didn't merged to latest stable build. I was deploying caprover first time and I just reinstalled whole system just because I thought something wrong in the captain server. Pretty annoying bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants