Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment non-validating data from the CCDH Pilot examples and fix CRDCH model so that they work correctly #39

Open
13 tasks
gaurav opened this issue Nov 18, 2021 · 1 comment
Open
13 tasks

Uncomment non-validating data from the CCDH Pilot examples and fix CRDCH model so that they work correctly #39

gaurav opened this issue Nov 18, 2021 · 1 comment

Comments

@gaurav
Copy link
Collaborator

gaurav commented Nov 18, 2021 •
edited
Loading

Currently non-validating data includes:

  • In ccdh-pilot/demonstrator-1:
    • Field identifier can't be validated correctly.
    • Field quantity_measure can't be validated correctly.
    • Field execution_time_observation can't be validated correctly.
    • Field primary_site can't be validated correctly.
    • Field observations can't be validated correctly.
    • Field stage can't be validated correctly.
  • In ccdh-pilot/demonstrator-2:
    • Field identifiers can't be validated correctly.
    • Field part_of can't be validated correctly.
    • Field associated_subject can't be validated correctly.
    • Field member_of_research_project can't be validated correctly.
    • Field primary_site can't be validated correctly.
    • Field observations can't be validated correctly.
    • Field diagnosis_date.date_time requires a complete date, not just a year. (see Add support for approximate dates ccdhmodel#130)

TODO: once PR #22 has been merged, this issue should be updated with links to the offending pieces of data.
This was referenced Nov 18, 2021
Open
Merged
gaurav added a commit that referenced this issue Jan 5, 2022
@gaurav
Merge pull request #22 from cancerDHC/add-pilot-examples
45bc7d3 
Adds the CCDH Pilots to the Example Data Repository. Some of these don't work, probably because of bugs in LinkML Runtime (#39). Others either can't be set up with the Python Data Classes or cannot be validated when they are (#40).
@gaurav
Copy link
Collaborator Author

gaurav commented Jan 6, 2022

This appears to be caused by the bug identified in linkml/linkml#463.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaurav