fix(generator): boolean conditions in template generator annotations #3570
+61
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillleader
changed the title
|
@chillleader Tested it, works great. Thank you very much, this update helped me a lot 🙂 |
DenovVasil
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add the missing property in the template generator annotations to create a condition that references a boolean property.
This possibility already exists on the lower level in the classes that are mapped to element template JSON, but it has been missing in the annotation.
An enum is used because we need to have a null/missing value, as the annotation can lead to different behavior of the generator based on which property is set.
Checklist
no milestonelabel.