Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message start event templates should not have a Correlation key (process) property #3224

Open
chillleader opened this issue Sep 4, 2024 · 3 comments
Assignees
Labels
kind:bug Something isn't working

Comments

@chillleader
Copy link
Member

Describe the Bug

All generated message start event element templates have both Correlation key (process) and Correlation key (payload). However, Correlation key (process) does not apply to message start event (since the process is not yet running and has no variables). Although present in the element template, this redundant property doesn't show up in the latest versions of the Modeler.

Steps to Reproduce

  1. Go to the Modeler
  2. Apply a message start event element template for any connector
  3. Make sure there is no Correlation key (process) in the properties panel
  4. Inspect the element template JSON and discover the Correlation key (process) property there

Expected Behavior

We should remove this property from all message start event templates

@chillleader chillleader added the kind:bug Something isn't working label Sep 4, 2024
@chillleader chillleader self-assigned this Sep 4, 2024
@chillleader
Copy link
Member Author

Concern: correlation key is needed for message start events inside subprocesses

@johnBgood
Copy link
Collaborator

johnBgood commented Sep 9, 2024

Discussion about the example below (https://camunda.slack.com/archives/C02JLRNQQ05/p1725454462715789)

Example BPNM:

simpleTest.bpmn.txt

@nikku
Copy link
Member

nikku commented Sep 9, 2024

We identified that correlationKey cannot simply be removed, but there is different use-cases for message start events:

  • Inside an event sub-process a correlationKey can be defined to tie the message subscription to the parent process instance
  • On the root scope correlationKey must not be defined.

The documentation currently states:

The binding name of correlationKey is not applicable to message start events on a process. In such cases, the property is automatically hidden.

So while this property is redundant in some scenarios, it is applicable in others, and our implementation should already handle that case (*).

* To be verified 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants