-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oauth2): add Spring Security OAuth2 documentation #1677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First-time read comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Do we need to add anything else on this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few more things about configs, logout, customizing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything added on the page? Are any commits missing or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I mixed the source up, I didn't add anything more here.
I don't think we need more, --oauth2
flag is specified and linked.
Hi @christinaausley, would have time to review this? It's not super urgent. We'll release docs around end of next week. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am done with the second round of feedback.
Co-authored-by: yanavasileva <[email protected]>
Co-authored-by: yanavasileva <[email protected]>
Co-authored-by: yanavasileva <[email protected]>
Co-authored-by: yanavasileva <[email protected]>
Co-authored-by: yanavasileva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good. Thank you for considering my feedback.
camunda/camunda-bpm-platform#4454