Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oauth2): add Spring Security OAuth2 documentation #1677

Merged
merged 12 commits into from
Oct 4, 2024

Conversation

danielkelemen
Copy link
Member

Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First-time read comments.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Do we need to add anything else on this page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few more things about configs, logout, customizing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything added on the page? Are any commits missing or?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I mixed the source up, I didn't add anything more here.
I don't think we need more, --oauth2 flag is specified and linked.

@danielkelemen
Copy link
Member Author

danielkelemen commented Sep 27, 2024

Hi @christinaausley, would have time to review this? It's not super urgent. We'll release docs around end of next week. Thank you!

Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am done with the second round of feedback.

Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good. Thank you for considering my feedback.

@danielkelemen danielkelemen merged commit dc3cf85 into master Oct 4, 2024
1 check passed
@danielkelemen danielkelemen deleted the 4454-oauth2-docs branch October 4, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants