Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to v14 #204

Closed
13 of 14 tasks
p-tombez opened this issue Nov 3, 2020 · 4 comments
Closed
13 of 14 tasks

Migration to v14 #204

p-tombez opened this issue Nov 3, 2020 · 4 comments

Comments

@leemannd
Copy link
Member

leemannd commented Nov 3, 2020

Missing module test_base_fileurl_field. IDK on which project it is used, but could be added right?

@p-tombez
Copy link
Member Author

p-tombez commented Nov 3, 2020

@leemannd It was not even migrated from 12 to 13, not sure if it is needed...

@leemannd
Copy link
Member

leemannd commented Nov 3, 2020

@p-tombez I know it wasn't, but it implements tests for a module that was migrated in V13 & V14. I think it is a good idea to migrate it (and the work today to have it migrated is about 5 minutes).

Sidenote my comment isn't ment to be blocking. But the cost is low and this should add security on a linked module.

@leemannd
Copy link
Member

leemannd commented Nov 4, 2020

@p-tombez It was migrated, but never reviewed ;) #190
Seems to be the good moment to take the opportunity to do it right?

@yvaucher yvaucher pinned this issue Apr 12, 2021
@nbessi nbessi closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants