Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefining window gives problems in IE9 #24

Open
lapo-luchini opened this issue Feb 1, 2018 · 1 comment
Open

Redefining window gives problems in IE9 #24

lapo-luchini opened this issue Feb 1, 2018 · 1 comment

Comments

@lapo-luchini
Copy link

Using var window gives a redeclaration error in IE9 (while, funnily enough, works OK in IE7):
image
Also, I'm not sure that declaration has any use, as the only line where window is used is already managed with (window||{}).
(part of the same might apply to var define and var module too, but they're not giving direct problems in IE9)

@caldwell
Copy link
Owner

caldwell commented Jun 2, 2018

The var window was put there in 8ff6353 to fix #11. It's so when it's being webpacked/browserified the window is declared locally (since in that case the whole file is wrapped in a function) and doesn't leak the renderjson export to the global window.

I'm not sure what the solution is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants