Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify name of binary in GitHub Releases tarballs #18

Open
jayvdb opened this issue Aug 3, 2024 · 3 comments
Open

Simplify name of binary in GitHub Releases tarballs #18

jayvdb opened this issue Aug 3, 2024 · 3 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Aug 3, 2024

https://github.com/cackle-rs/cackle/releases/tag/v0.8.0 tarball contains a file cackle-v0.8.0-x86_64-unknown-linux-musl.

Usually github release tarballs only contain the binary, with the expected binary name if cargo install was used. i.e. cargo-acl in this case.

I am trying to add this tool to a github action which installs from github releases, and doesnt have the ability to understand the filename in the tarball. c.f. taiki-e/install-action#604

@davidlattimore
Copy link
Collaborator

I assume you've seen cackle-action and need to do something different?

I'm open to changing the name, but I'll need to think about whether that will break the existing action and if so, how best to fix it.

@jayvdb
Copy link
Contributor Author

jayvdb commented Aug 3, 2024

Ya, I have seen that. We prefer to use a single github action for installations, and use as few as possible over all - each one becomes SOUP and needs to be risk-accessed & documented.

@davidlattimore
Copy link
Collaborator

I just checked and it looks like the binary is already called cargo-acl. It's in a directory that includes the version and target, but the binary has just a simple name. This is consistent with other packages like ripgrep do their releases. Perhaps you can just get tar to strip the directory when you unpack? e.g.

tar -x --strip-components=1 -f something.tar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants