-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathfinding can fail with IllegalStateException
when sneaking off a block
#4528
Comments
Couldn't reproduce. Do you have baritone somehow configured so that it walks over the hole? I don't get an error if it parkours over the hole or falls into it. |
Yes, I used default settings (i.e. no parkour) and had a dirt block in my hand so it would scaffold back over the hole. |
This is indeed a tricky case because the "correct" path here does indeed double back on itself! |
I think we can either fix the sanity check so it runs before we add the new node or only add the node if A* returned nothing (should be equal to checking if pathStart = goal like in the original solution) |
not sure if that works, wouldn't that make it fall into the hole in this example without placing the block? or no? |
The pathfinder would still start above the supporting block so no, unless it also did so for the last couple years. |
It would just make it walk onto the supporting block(pathStart()) which should be the goal if A* returned nothing |
Some information
Operating system: Linux
Java version: 21
Minecraft version: 1.20.6
Baritone version: fd8af9b
Other mods (if used): Litematica 1.18.1 + Malilib 1.19.0
(i.e. the workspace I used to test #4527)
Exception, error or logs
How to reproduce
Sneak off of an edge and set a goal such that the shortest path from the supporting block to the goal leads through your current position, then start the pathfinder.
E.g. like this:
Modified settings
None
Final checklist
The text was updated successfully, but these errors were encountered: