Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASI randomness should not require a mutex #5660

Open
abrown opened this issue Jan 30, 2023 · 0 comments
Open

WASI randomness should not require a mutex #5660

abrown opened this issue Jan 30, 2023 · 0 comments
Labels
wasm-proposal:threads Issues related to the WebAssembly threads proposal

Comments

@abrown
Copy link
Contributor

abrown commented Jan 30, 2023

In #5484, in order to handle mutability in the WasiCtx table, the source of randomness in wasi-common was wrapped in a Mutex. This solves the compiler errors related to mutable access of the the field, but there is surely some refactoring that avoids locking altogether.
@abrown abrown changed the title WASI randomness does not need a mutex WASI randomness should not require a mutex Jan 30, 2023
@alexcrichton alexcrichton added the wasm-proposal:threads Issues related to the WebAssembly threads proposal label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wasm-proposal:threads Issues related to the WebAssembly threads proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @abrown