Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upkeep #233

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Upkeep #233

merged 9 commits into from
Oct 3, 2023

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Oct 3, 2023

First part

  • Remove docs dir
  • Remove testthat:: as testthat is always loaded when testing (testthat also loads when you call load_all()
  • remove library(modeltime) from examples
  • Update GH actions
  • Remove .DS_Store and adding to gitignore
  • Remove roxygen2 and covr from Suggests

@olivroy
Copy link
Contributor Author

olivroy commented Oct 3, 2023

@mdancho84 CI passing except for a vignette.

Quitting from lines 62-63 [unnamed-chunk-3] (modeltime-spark.Rmd)
Error: processing vignette 'modeltime-spark.Rmd' failed with diagnostics:
ignoring SIGPIPE signal
--- failed re-building ‘modeltime-spark.Rmd’

I can investigate in the follow-up PR where I will also fix the deprecation warnings from tidyverse and tidymodels and remove deps on tidyverse and tidymodels.

@mdancho84
Copy link
Contributor

Java and Spark are added in the R-CMD-check and pkgdown.yaml

They are needed for the Spark vignette.

@mdancho84
Copy link
Contributor

I'm rerunning. It's odd that only the ubuntu-latest release is failing.

@olivroy
Copy link
Contributor Author

olivroy commented Oct 3, 2023

Also getting a warning that the java and python actions are deprecated. Using a more recent version.

Should a recent version of Spark be used too? 3.1.2 is two years old

Edit added the default distribution for java https://github.com/actions/setup-java#supported-distributions

@mdancho84
Copy link
Contributor

I reran the failed test, and it's working fine. For whatever reason every once in a while we'll get a false negative with a test failure.

@mdancho84 mdancho84 merged commit 59a33a9 into business-science:master Oct 3, 2023
6 checks passed
@olivroy
Copy link
Contributor Author

olivroy commented Oct 3, 2023

Indeed. And the run with updated actions is on track to succeed.

The node16 warnings are also gone!

@olivroy olivroy deleted the upkeep branch October 3, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants