Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of lifecycle image os/arch should be more flexible #2163

Open
natalieparellano opened this issue May 22, 2024 · 0 comments
Open
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.

Comments

@natalieparellano
Copy link
Member

Description

Right now, we hard code the supported lifecycle os/arch combinations. #2086 will expand the list of supported architectures (search for SupportedLinuxArchitecture) to include ppc64le and s390x as the lifecycle now supports those. However, this is brittle, and it will be annoying to have to modify pack every time the lifecycle supports a new architecture. We should read the lifecycle image (buildpacksio/lifecycle) manifest list to determine the supported architectures.

Additionally, when the requested architecture is not found, we currently just fall back to linux/amd64 which seems sub-optimal. #2086 adds a warning but we should probably turn this into an error case.

@natalieparellano natalieparellano added type/chore Issue that requests non-user facing changes. status/triage Issue or PR that requires contributor attention. labels May 22, 2024
@jjbustamante jjbustamante added status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels May 22, 2024
@natalieparellano natalieparellano added the help wanted Need some extra hands to get this done. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

No branches or pull requests

2 participants