Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fully qualified image names (podman compatibility) #1218

Closed
2 tasks
FlorianLudwig opened this issue Jun 29, 2021 · 10 comments · Fixed by #2185
Closed
2 tasks

Use fully qualified image names (podman compatibility) #1218

FlorianLudwig opened this issue Jun 29, 2021 · 10 comments · Fixed by #2185
Assignees
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.

Comments

@FlorianLudwig
Copy link

FlorianLudwig commented Jun 29, 2021

Description

For podman compatibility (and more) it would be good to use fully qualified image names ( = include registry in image name)

Example: Instead of:

buildpacksio/lifecycle:0.11.3

use:

docker.io/buildpacksio/lifecycle:0.11.3

Changes

  • Update internal references to images to include registry
  • Update docs to use fully qualified image names in examples

Additional context

See also:

@FlorianLudwig FlorianLudwig added status/triage Issue or PR that requires contributor attention. type/enhancement Issue that requests a new feature or improvement. labels Jun 29, 2021
@matejvasek
Copy link
Contributor

Not only podman compatibility, it should be also safer.

@jromero
Copy link
Member

jromero commented Jun 29, 2021

I like this suggestion although I know there will be some necessary discussion about ease-of-use considering that there's a large number of users that are coming from the docker CLI where the host is assumed if missing.

@FlorianLudwig
Copy link
Author

@jromero

changing:

const DefaultLifecycleImageRepo = "buildpacksio/lifecycle"

would not be visible end-user facing. So at least for that part, no ease-of-use consideration would be necessary?

Updating the docs so that all examples include the host might be different.

I do not want to suggest to enforce only accepting image names that contain the host.

@jromero
Copy link
Member

jromero commented Aug 10, 2021

@FlorianLudwig I would say that we are on the same page.

  1. We should update the reference to lifecycle image
  2. Update the docs to include host (I am curious how this would affect image names for images that are only intended to live on the docker daemon. I'm assuming you would still set the host to docker.io which might be contentious).
  3. We should NOT enforce only accepting image names that contain a host.

@jromero jromero added status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Aug 10, 2021
@natalieparellano natalieparellano added help wanted Need some extra hands to get this done. good first issue A good first issue to get started with. labels Aug 21, 2023
@hhiroshell
Copy link
Contributor

I'm thinking about giving it a try.
But what's the meaning of the contribfest label? Is there anything that should be considered when working on this issue?

@natalieparellano
Copy link
Member

@hhiroshell it would be great to get your help on this! Re the label, we flagged this issue for a Contribfest session that we hosted at KubeCon EU, but the issue is still up for grabs.

@hhiroshell
Copy link
Contributor

Thanks @natalieparellano, so could you please assign this to me?

@hhiroshell
Copy link
Contributor

Now, I'm working on fixing documentation at buildpacks/docs#702.

@hhiroshell
Copy link
Contributor

hhiroshell commented May 31, 2024

To the reviewers,

The document is now ready for review.

I apologize for the relatively large pull request, as the entire document has been revised.

@hhiroshell
Copy link
Contributor

Completed for works no the codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants