Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning message when saving a local image (daemon) and containerd storage is enable #282

Open
jjbustamante opened this issue Nov 6, 2024 · 0 comments
Labels
help wanted Need some extra hands to the this done. type/enhancement New feature or request

Comments

@jjbustamante
Copy link
Member

jjbustamante commented Nov 6, 2024

There is a known performance issue when using containerd storage, #276 based on this ticket on pack we want to add some warning message when saving an image to the daemon and using containerd

Some hints

  • Add a new WithLogger() option here
  • Modify the Store constructor, to also receive a Logger
  • Update the logic for local.NewImage() to check if we received the Logger option, in such as case, update the creation of the Store here to pass through that Logger instance.
  • At this point, the Store has a valid logger instance to print the warning message during the Image.Save operation without having to change the signature. It will depend on imageutil consumer to set the logger and if the logger is not set, we skip trying to print the warning, this must avoid breaking things.
@jjbustamante jjbustamante added type/enhancement New feature or request help wanted Need some extra hands to the this done. labels Nov 6, 2024
wuhenggongzi added a commit to wuhenggongzi/imgutil that referenced this issue Nov 10, 2024
This commit enhances the Logger functionality by integrating it with the existing
automatic detection of the storage driver type in the NewStore function.
The Logger interface has been added to log warnings related to the containerd storage driver.
Test cases have been created to ensure that warnings are logged correctly when using containerd.

Signed-off-by: Skylar <[email protected]>
wuhenggongzi added a commit to wuhenggongzi/imgutil that referenced this issue Nov 10, 2024
This commit enhances the Logger functionality by integrating it with the existing
automatic detection of the storage driver type in the NewStore function.
The Logger interface has been added to log warnings related to the containerd storage driver.
Test cases have been created to ensure that warnings are logged correctly when using containerd.

Signed-off-by: wuhenggongzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need some extra hands to the this done. type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant