You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a known performance issue when using containerd storage, #276 based on this ticket on pack we want to add some warning message when saving an image to the daemon and using containerd
Modify the Store constructor, to also receive a Logger
Update the logic for local.NewImage() to check if we received the Logger option, in such as case, update the creation of the Storehere to pass through that Logger instance.
At this point, the Store has a valid logger instance to print the warning message during the Image.Save operation without having to change the signature. It will depend on imageutil consumer to set the logger and if the logger is not set, we skip trying to print the warning, this must avoid breaking things.
The text was updated successfully, but these errors were encountered:
This commit enhances the Logger functionality by integrating it with the existing
automatic detection of the storage driver type in the NewStore function.
The Logger interface has been added to log warnings related to the containerd storage driver.
Test cases have been created to ensure that warnings are logged correctly when using containerd.
Signed-off-by: Skylar <[email protected]>
This commit enhances the Logger functionality by integrating it with the existing
automatic detection of the storage driver type in the NewStore function.
The Logger interface has been added to log warnings related to the containerd storage driver.
Test cases have been created to ensure that warnings are logged correctly when using containerd.
Signed-off-by: wuhenggongzi <[email protected]>
There is a known performance issue when using containerd storage, #276 based on this ticket on
pack
we want to add some warning message when saving an image to the daemon and using containerdSome hints
WithLogger()
option hereStore
constructor, to also receive aLogger
local.NewImage()
to check if we received theLogger
option, in such as case, update the creation of theStore
here to pass through that Logger instance.Store
has a valid logger instance to print the warning message during the Image.Save operation without having to change the signature. It will depend on imageutil consumer to set the logger and if the logger is not set, we skip trying to print the warning, this must avoid breaking things.The text was updated successfully, but these errors were encountered: