Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kp secret create --registry does not correctly parse registries #324

Closed
fcaroline2020 opened this issue Jul 21, 2023 · 0 comments · Fixed by #328
Closed

kp secret create --registry does not correctly parse registries #324

fcaroline2020 opened this issue Jul 21, 2023 · 0 comments · Fixed by #328
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@fcaroline2020
Copy link
Contributor

Summary

When using kp secret create --registry https://index.docker.io/v1/ the secret is erroneously created.

Expected Secret Data

{"auths":{"https://index.docker.io/v1/":{"username":"....

Actual Secret Data

{"auths":{"https:":{"username":"....

Workaround

In the meantime use flags --dockerhub and --gcr instead as these are correctly generating secrets

Solution

Remove logic that tries to parse the registry host if the user passes in the whole path to the repo

@fcaroline2020 fcaroline2020 added bug Something isn't working good first issue Good for newcomers labels Jul 21, 2023
@fcaroline2020 fcaroline2020 self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
1 participant