Support installing/running with pipx - fixes #238 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The curl plugin for peru uses the following as its shebang line:
#! /usr/bin/env python3
If the user is using pipx, then the system Python interpreter —
`/usr/bin/env python3` — likely does not have the peru package
installed.
Before this change the curl plugin always uses a `get_version` function
from the peru package and therefore will error if the Python interpreter
does not have the peru package installed.
After this change the curl plugin can succeed with only standard library
modules available.
|
What would it take to get this merged? I submitted the initial issue and l have found |
|
@oconnor663 @olson-sean-k if this were re-opened, could you merge it? I ran into this issue again on a new system and it took me half a day to remember how to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The curl plugin for peru uses the following as its shebang line:
If the user is using pipx, then the system Python interpreter —
/usr/bin/env python3— likely does not have the peru package installed.Before this change the curl plugin always uses a
get_versionfunction from the peru package and therefore will error if the Python interpreter does not have the peru package installed.After this change the curl plugin can succeed with only standard library modules available.
Fixes #238