Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow curl module to be used as http module #217

Open
felipefoz opened this issue Aug 31, 2021 · 2 comments
Open

Allow curl module to be used as http module #217

felipefoz opened this issue Aug 31, 2021 · 2 comments

Comments

@felipefoz
Copy link
Contributor

As mentioned and briefly discussed in #195 by @oconnor663 and @colindean, the curl module today in peru is not actually using curl, which is confusing and can lead to wrong conclusions.

The proposal here is to create an alias for the curl module to be also recognized as http.

And then in future versions we keep only http as the module using the requests library.

@oconnor663
Copy link
Member

Could we be concrete about what confusions result from the current name. For example, what specific things does Curl do with e.g. your ~/.netrc file, where peru might surprise people by not doing that thing? Is there anything besides ~/.netrc?

@felipefoz
Copy link
Contributor Author

felipefoz commented Sep 2, 2021

Yes, I believe software should clearly inform its intent. In this case, the curl module make us think that curl is used for downloading the packages, as the git module uses git for downloading git repositories.
Wouldn't it be a surprise for you that the git module actually was using other software than git?

That happened to me when I discovered that curl was not actually curl, while I haven't explored yet all that curl can do differently besides .netrc, as you mentioned.

The point is: the name is not suitable and even http might not be either, but we could be more clear on that, couldn't we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants