Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Stop reading file, tag not defined... #55

Open
jclink opened this issue Oct 28, 2019 · 2 comments
Open

Stop reading file, tag not defined... #55

jclink opened this issue Oct 28, 2019 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jclink
Copy link

jclink commented Oct 28, 2019

Not so much of an issue, but I was getting a lot of system messages such as failed to close resource, tag not defined, stop reading file-offset may cause infinite loop...

I cleared them all by:
changing import to the androidx ExifInterface.
changing the dependency to: implementation 'androidx.exifinterface:exifinterface:1.1.0-rc01' in the build gradle.
Changed tag 'IsoSpeedRatings' to 'PhotographicSensitivity'.
Added calls to Reset(), Close() for the ByteArrayOutputStream bos object.

None of these were causing errors or crashing the app, so this is more of an FYI rather than an issue.

@btastic btastic added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 28, 2020
@btastic
Copy link
Owner

btastic commented Jan 28, 2020

I am leaving this open for some one wanting to contribute to this library as a good first issue.

Thanks for bringing this to my attention.

@JamesMcIntosh
Copy link

Hi @jclink,
Why did you change ISOSpeedRatings to PhotographicSensitivity?
Also why were you calling reset for the ByteArrayOutputStream, shouldn't it be garbage collected as all references have been discarded as soon as the method finishes?
Many thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants