Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to avoid memory leaks?????????? #92

Open
Dencer opened this issue Aug 28, 2018 · 2 comments
Open

how to avoid memory leaks?????????? #92

Dencer opened this issue Aug 28, 2018 · 2 comments
Labels

Comments

@Dencer
Copy link

Dencer commented Aug 28, 2018

I can see ngondestroy in the cheatsheet but not in hotkey.ts

@wittlock
Copy link
Collaborator

Have you seen any memory leak? Could you provide some example code of the situation that's troublesome? Or a pull request that amends it? Or an article describing the issue?

When I use this myself I run hotkeyservice.remove() on my hotkeys on my own components OnDestroy and that seems to be working well. But I might be missing something, but I could use something more concrete to work with.

@Coffee-Tea
Copy link
Collaborator

@Dencer any reply here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants