diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 4420cad4..2bad1dde 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -3,6 +3,12 @@ # Griffin maintainers are responsible for all machinery in this repository. * @brave/griffin-maintainers -# The seed file is owned by the uplift team as any change to it directly affects -# public builds. It's important to update the seed in a controlled manner. -/seed/seed.json @brave/uplift-approvers +# The seed directory is deprecated and no longer used for the seed generation. +# However, it is used by the perf infrastructure to access the Griffin seed at +# some point in the past. Lock it to Griffin maintainers to prevent any +# unrelated changes. +/seed/** @brave/griffin-maintainers + +# The studies are owned by the uplift team as any change directly affects public +# builds. It's important to update studies in a controlled manner. +/studies/*.json5 @brave/uplift-approvers diff --git a/.github/workflows/generate-test-seed.yml b/.github/workflows/generate-test-seed.yml index c8a849ea..a79f8efa 100644 --- a/.github/workflows/generate-test-seed.yml +++ b/.github/workflows/generate-test-seed.yml @@ -4,7 +4,6 @@ on: pull_request: paths: - '.github/workflows/generate-test-seed.yml' - - 'seed/seed.json' - 'studies/**' jobs: @@ -23,14 +22,6 @@ jobs: - name: Fetch base commit run: git fetch --depth=1 origin "$BASE_SHA" - - name: Setup Python - uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5 - with: - python-version: '3.11' - - - name: Install python requirements - run: pip install -r seed/requirements.txt - - name: Comment "Generation In Progress" uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 with: @@ -64,10 +55,7 @@ jobs: - name: Generate seed run: | - # Use only python implementation for now. - python seed/serialize.py seed/seed.json --version "$SEED_VERSION" - # TODO: enable this when per-file studies will be synced with seed.json. - # npm run seed_tools -- create_seed studies seed.bin --version "$SEED_VERSION" + npm run seed_tools create -- --version "$SEED_VERSION" - name: Upload seed env: diff --git a/.github/workflows/test-src.yml b/.github/workflows/test-src.yml index 5d0b05fd..d091ba01 100644 --- a/.github/workflows/test-src.yml +++ b/.github/workflows/test-src.yml @@ -24,3 +24,14 @@ jobs: - name: build run: npm run build + + - name: Setup Python + uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5 + with: + python-version: '3.11' + + - name: Install python seed generator requirements + run: pip install -r seed/requirements.txt + + - name: Compare python and typescript seed generator + run: npm run seed_tools compare_python_gen diff --git a/README.md b/README.md index 6a9dea36..b09435f4 100644 --- a/README.md +++ b/README.md @@ -9,36 +9,42 @@ See the [Wiki](