Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providers for BTC/ZCash only show up when trying to select token from list and not from Portfolio #42083

Open
1 of 6 tasks
srirambv opened this issue Nov 5, 2024 · 1 comment · May be fixed by brave/brave-core#26419
Open
1 of 6 tasks

Providers for BTC/ZCash only show up when trying to select token from list and not from Portfolio #42083

srirambv opened this issue Nov 5, 2024 · 1 comment · May be fixed by brave/brave-core#26419
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2024 •
edited
Loading

Description

Providers for BTC/ZCash only show up when trying to select token from list and not from Portfolio

Steps to reproduce

  1. Create Bitcoin account
  2. Select Buy from BTC token menu in portfolio
  3. Buy screen shows but doesn't show message for providers
  4. Repeat the same steps for ZCash, same result

Actual result

Image

Expected result

Do not show Buy option for BTC/ZCash if not supported

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.73.70 Chromium: 131.0.6778.24 (Official Build) nightly (64-bit)
Revision 4ee1e6a55149299c882bbe53c0fc6ef5093b0b15
OS Windows 11 Version 23H2 (Build 22631.4317)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @Douglashdaniel @kleantzogu
@srirambv
Copy link
Contributor Author

srirambv commented Nov 5, 2024

This is weird. If I change tokens and go back to BTC/ZCash I get the providers list

brave_y5T48CyVCo.mp4

@srirambv srirambv changed the title Do not show Buy option for Bitcoin and Zcash Providers for BTC/ZCash only show up when trying to select token from list and not from Portfolio Nov 5, 2024
@Douglashdaniel Douglashdaniel self-assigned this Nov 6, 2024
@Douglashdaniel Douglashdaniel linked a pull request Nov 6, 2024 that will close this issue
Open
24 tasks
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/exclude
Projects
Web3
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wallet): BTC and ZEC Buy Quotes from Route brave/brave-core
2 participants
@srirambv @Douglashdaniel