Brave should depend on upstream WebTorrent; Create de-facto "chromeapp" field in package.json spec #5587
Labels
feature/webtorrent
Label for webtorrent related issues
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
To resolve #856 and obviate the need for Brave to use a WebTorrent fork, I'm attempting to make a defacto standard for specifying Chrome App dependency substitutions using the
"chromeapp"
field inpackage.json
.The
"chromeapp"
field is just like the"browser"
field inpackage.json
except it's intended for Chrome Apps instead of a generic browser environment. Bundler tools likebrowserify
orwebpack
can be configured to look for the"chromeapp"
field instead of the"browser"
field when doing a build for a Chrome App.In the case of WebTorrent running in a Chrome App context in Brave, we can use raw sockets, so we want to replace e.g.
require('net')
withrequire('chrome-net')
and similar.I'm sending PRs to all dependent projects:
package.json
jscissr/http-node#2package.json
webtorrent/webtorrent#1691package.json
webtorrent/torrent-discovery#45package.json
mafintosh/k-rpc-socket#17package.json
webtorrent/bittorrent-tracker#328Once this is complete, we should be able to depend directly on upstream WebTorrent.
The text was updated successfully, but these errors were encountered: