Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update l10n for 1.62.x (Chromium 121). #35369

Closed
mkarolin opened this issue Jan 17, 2024 · 3 comments · Fixed by brave/brave-core#21675
Closed

Update l10n for 1.62.x (Chromium 121). #35369

mkarolin opened this issue Jan 17, 2024 · 3 comments · Fixed by brave/brave-core#21675
Assignees
@mkarolin
Labels
l10n OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.62.x - Release

Comments

@mkarolin
Copy link
Contributor

Download the latest l10n from Transifex.

Test plan:

@brave/legacy_qa should run through a few locals just to make sure that nothing obvious has regressed. Shouldn't spend too much time on this though.
@mkarolin mkarolin added l10n QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 17, 2024
@mkarolin mkarolin self-assigned this Jan 17, 2024
@mkarolin mkarolin mentioned this issue Jan 20, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.62.x - Release milestone Jan 22, 2024
@kjozwiak
Copy link
Member

Closing as the above was merged into 1.62.x as per brave/brave-core#21661 (review). The above requires 1.62.149 or higher for 1.62.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 22, 2024 •
edited
Loading

Verification PASSED on

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (64-bit)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | Windows 10 Version 22H2 (Build 19045.3930)

Third-party cookies

  • Confirmed that the Cookies and other site data settings name is renamed to Third-party cookies is translated into other locales like Germany, France, Kannada and Hindi
  • Confirmed that the strings which are changed in cookies page as part of CR121 are translated in other locales like Germany, France, Kannada and Hindi
Germany Germany France France Kannada Kannada Hindi Hindi
image image image image image image image image

Security

  • Strings which are changed in Security tab are translated into other locales like Germany, France, Kannada and Hindi
Germany France Kannada Hindi
image image image image

Bookmarks Add

  • Confirmed that the Bookmarks Add modal popup strings are translated into other locales like Germany, France, Kannada and Hindi
Germany France Kannada Hindi
image image image image

On-device site data

  • Confirmed that the content settings On-device site data which is added as part of CR121 is translated into other locales like Germany, France, Kannada and Hindi
Germany France Kannada Hindi
image image image image

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jan 22, 2024
Closed
This was referenced Jan 22, 2024
Merged
Merged
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 23, 2024
@hffvld
Copy link
Contributor

hffvld commented Jan 24, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP11.231215.007 release-keys
Brave build: 1.62.150
Chromium: 121.0.6167.85 (Official Build) (64-bit)

ACTUAL RESULTS:

  • Verified existing and new strings
  • Verified in multiple languages: Russian, Spanish, French, German, Japanise and Arabic
Russian
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
Spanish
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
French
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
German
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
Japanise
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
Arabic
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
l10n OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

Updated l10n for 1.62.x release (lowered to master). brave/brave-core
5 participants
@kjozwiak @GeetaSarvadnya @mkarolin @brave-builds @hffvld