Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Keyboard Shortcuts more Discoverable #28329

Closed
fallaciousreasoning opened this issue Feb 7, 2023 · 5 comments · Fixed by brave/brave-core#16845
Closed

Make Keyboard Shortcuts more Discoverable #28329

fallaciousreasoning opened this issue Feb 7, 2023 · 5 comments · Fixed by brave/brave-core#16845
Assignees
Labels

Comments

@fallaciousreasoning
Copy link

Currently, we have a lot of shortcuts but it's hard for user's to discover them. We should add a page where it's possible to view all available shortcuts.

This is a prerequisite for #354, where we want to make the shortcuts configurable.

@LaurenWags
Copy link
Member

@fallaciousreasoning is this issue solely to expose the page via the flag mentioned in brave/brave-core#16845? Asking as my brave://commands does not look as pictured so I want to be sure I'm checking the correct thing here.

Using 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (x86_64):

Screen Shot 2023-03-14 at 11 55 46 AM

@fallaciousreasoning
Copy link
Author

Interesting - I think it should be showing keyboard shortcuts too (it definitely does on Linux)
image

I've got another PR which is going to make a bunch of changes to this, might be worth holding off on this till it lands
brave/brave-core#17296

@LaurenWags
Copy link
Member

@fallaciousreasoning I see, unless that's going to be uplifted to 1.50.x, we still need to figure out what we're doing for this issue. Perhaps this one should be QA/No - esp if it's not fully baked?

wdyt @rebron?

@fallaciousreasoning
Copy link
Author

fallaciousreasoning commented Mar 15, 2023

QA/No is probably a good call - I'll update it 😄 Sorry about that!

@LaurenWags
Copy link
Member

thanks @fallaciousreasoning 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants