Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tPAC issues #618

Open
Moo-Marc opened this issue May 8, 2023 · 0 comments
Open

tPAC issues #618

Moo-Marc opened this issue May 8, 2023 · 0 comments

Comments

@Moo-Marc
Copy link
Collaborator

Moo-Marc commented May 8, 2023

A few issues have come up related to phase-amplitude coupling. I'm making this issue to keep track of what needs our attention.

  1. The recent code changes for tPAC Bugfix tPAC #611 most likely need to be applied in related PAC processes: surrogate tPAC and inter-regional (IR) tPAC. (others?)
  2. More generally, the 3 functions should be made consistent, ideally reuse the same code, the tPAC Compute function for example. Currently, IR does interpolation and averaging differently for example.
  3. On top of fixes to the PAC averaging process pac and tpac averaging bug fixes #617, there's a need to clarify and/or correct what the averaging option does within the tPAC process itself.
    process_pac_dynamic: concatenates the "full" arrays (DynamicPAC field) which is already peak values in f_P, while averaging the "max across f_A" values (TF field). This is currently inconsistent with visualization (only displays first trial).
    process_pac_dynamic_sur2: no documentation in code or tutorials of what this does. Averaging is same as in process_pac_dynamic.
    process_pac_ir_dynamic: this one computes the average of DynamicPAC, unlike the other 2.
  4. Code documentation is lacking.
  5. IR doesn't properly deal with unconstrained sources for the "seed" side (but no error). And it uses the "seed" vertex only, which isn't clear. Probably a scout function should be used instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant