Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose brainglobe tools as napari plugins? #41

Open
adamltyson opened this issue Jan 9, 2024 · 6 comments
Open

Expose brainglobe tools as napari plugins? #41

adamltyson opened this issue Jan 9, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@adamltyson
Copy link
Member

We can now pip install brainglobe, but within the napari plugin dialog, users still have to install plugins one by one. Until we have a meta-plugin I wonder if it's worth enabling a single brainglobe installation option based on this meta-package.

cc @alessandrofelder @willGraham01

@adamltyson adamltyson added the enhancement New feature or request label Jan 9, 2024
@willGraham01
Copy link
Collaborator

I (niavely) claim that the metapackage ships the napari plugins and installs them to boot.

$ mamba create -y -n napari-plugins python=3.10
$ pip install brainglobe
$ napari

Then opening napari and heading to the plugin menu I can see:

image

Clicking on them immediately brings up the respective widgets.

@adamltyson
Copy link
Member Author

That works, but users can't install the plugins all in one go using the napari plugin installation GUI.

@willGraham01
Copy link
Collaborator

That works, but users can't install the plugins all in one go using the napari plugin installation GUI.

Gotcha, sorry didn't fully grasp the initial premise 😅 I'm no expert but theoretically adding the various napari metadata files to turn this package into a plugin should do the trick then, right? Even if there's no acutal "pluign content"? @alessandrofelder might be able to confirm/deny my hypothesis

@adamltyson
Copy link
Member Author

I think so. The only consideration would be what else we're shipping in case that causes compatibility problems with napari etc.

@adamltyson
Copy link
Member Author

Although in theory, we should be looking out for that anyway.

@alessandrofelder
Copy link
Member

adding the various napari metadata files to turn this package into a plugin should do the trick then, right?

I think so too 🤞

we should be looking out for that anyway.

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants