Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support form group for undefined start event #972

Open
marcellobarile opened this issue Sep 13, 2023 · 5 comments
Open

Support form group for undefined start event #972

marcellobarile opened this issue Sep 13, 2023 · 5 comments
Labels
backlog Queued in backlog enhancement New feature or request

Comments

@marcellobarile
Copy link

Is your feature request related to a problem? Please describe.

While working on https://github.com/camunda/web-modeler/issues/4583, to enable the form linking for a start event, we had to copy/paste code from the core libraries in order to have the form group rendered also for such an element.

Describe the solution you'd like

The properties panel should have the form group also for the undefined start event; note that so far this feature is only supported by the web-modeler.

Additional context

Current implementation in the web-modeler:
image

Duplicated code on the web-modeler:
https://github.com/camunda/web-modeler/blob/56fa51c7ec6a65f7942af360de286ab83bd774bb/webapp/src/App/Pages/Diagram/Publication/publicationPropertiesGroupExtension/FormGroup/FormProperties.js

@marcellobarile marcellobarile added the enhancement New feature or request label Sep 13, 2023
@smbea smbea added the ready Ready to be worked on label Sep 19, 2023
@smbea
Copy link
Contributor

smbea commented Sep 19, 2023

We should expose the group API in order to avoid the copy/paste

@CatalinaMoisuc
Copy link
Member

CatalinaMoisuc commented Sep 19, 2023

Let's spend ~1h to understand the effort we need to ship proper groups API and post an assessment in the issue and then decide on priority and capacity.

@barmac barmac transferred this issue from bpmn-io/properties-panel Sep 21, 2023
@barmac
Copy link
Member

barmac commented Sep 21, 2023

I transferred this issue from bpmn-io/properties-panel as Form group is implemented in bpmn-js-properties-panel.

If I understand it correctly, you request that we add the form group for bpmn:StartEvent in the Zeebe Properties Provider. So it's not about exposing any groups (via export), but rather supporting a missing feature in bpmn-js-properties-panel.

Apart from adding the group in the properties panel, we'd need to adjust zeebe-bpmn-moddle to make sure the form related properties are kept when a Start Event is copied (https://github.com/camunda/zeebe-bpmn-moddle/blob/main/resources/zeebe.json#L282). Also, we'd need to make sure the properties are removed when None Start Event is transformed into a specified event, e.g. Timer Start Event.

@marcellobarile please let me know if I understood the issue correctly.

@barmac barmac removed their assignment Sep 21, 2023
@barmac
Copy link
Member

barmac commented Sep 21, 2023

To clarify further, if I deploy from Desktop Modeler or another client but not Web Modeler, this feature doesn't work, does it?

@CatalinaMoisuc
Copy link
Member

We reviewed this with the last planning and decided to move this back to backlog because it is not a trivial fix and for the time being this feature is still experimental and only available in SaaS and not Self-Managed. When we pick it up for implementation also into Self-Managed, we can bring it back to Ready.

@barmac barmac added backlog Queued in backlog and removed ready Ready to be worked on labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants