Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override an existing properties panel component behaviour #737

Open
Ichigo85 opened this issue Aug 5, 2022 · 5 comments
Open

Override an existing properties panel component behaviour #737

Ichigo85 opened this issue Aug 5, 2022 · 5 comments
Assignees
Labels
backlog Queued in backlog enhancement New feature or request

Comments

@Ichigo85
Copy link

Ichigo85 commented Aug 5, 2022

Is your feature request related to a problem? Please describe

I am working on upgrading my plugins to Camunda Modeler 5.0 and I am a bit stuck on a thing. I have to edit the behaviour of an existing field on properties panel (in my case, the MessageRef field) because I need to call one of my specific events on setValue.
Is there a simple way to do it without re-writing the component and replacing it on the propertiesProvider#getGroups call?

Describe the solution you'd like

Support to override a field component, possibly without completely rewriting it, but only parts of it (getter, setter, validate, ...).

Describe alternatives you've considered

The only way I considered, as I said, is to re-write the existing behaviour of the field, overriding the setValue and adding my code.

Additional context

@Ichigo85 Ichigo85 added the enhancement New feature or request label Aug 5, 2022
@pinussilvestrus
Copy link
Contributor

Cross-posting my answer from the Camunda forum: https://forum.camunda.io/t/is-there-a-simple-way-to-override-a-properties-panel-component-behaviour/39156/2.

I think this should rather be a feature request in the properties panel project: https://github.com/bpmn-io/bpmn-js-properties-panel/issues/new/choose

@pinussilvestrus pinussilvestrus added the help wanted Extra attention is needed label Aug 5, 2022
@pinussilvestrus pinussilvestrus transferred this issue from bpmn-io/bpmn-js-examples Aug 5, 2022
@pinussilvestrus pinussilvestrus changed the title Add example for overriding an existing properties panel component behaviour Overriding an existing properties panel component behaviour Aug 5, 2022
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Aug 5, 2022

I transferred the issue accordingly, thanks for the request 👍

I think that would be an interesting slack time topic.

@pinussilvestrus pinussilvestrus changed the title Overriding an existing properties panel component behaviour Override an existing properties panel component behaviour Aug 5, 2022
@pinussilvestrus pinussilvestrus removed the help wanted Extra attention is needed label Aug 5, 2022
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label Aug 15, 2022 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus self-assigned this Aug 20, 2022
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Aug 26, 2022

Slack time (2nd Sep. 2022)

Idea(s):

Miro: https://miro.com/app/board/uXjVPaDdxHs=/

Branches:

pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Sep 2, 2022
pinussilvestrus pushed a commit that referenced this issue Sep 2, 2022
pinussilvestrus pushed a commit that referenced this issue Sep 2, 2022
pinussilvestrus pushed a commit to bpmn-io/properties-panel that referenced this issue Sep 12, 2022
pinussilvestrus pushed a commit that referenced this issue Sep 12, 2022
pinussilvestrus pushed a commit that referenced this issue Sep 12, 2022
pinussilvestrus pushed a commit that referenced this issue Sep 12, 2022
pinussilvestrus pushed a commit that referenced this issue Sep 12, 2022
@Ichigo85
Copy link
Author

Hi @pinussilvestrus! Any news about this issue?

@pinussilvestrus
Copy link
Contributor

Unfortunately not. this issue is not on our roadmap currently (cf. backlog label).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants