Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header and body seperately renderable #701

Open
christian-konrad opened this issue Jun 9, 2022 · 5 comments
Open

Header and body seperately renderable #701

christian-konrad opened this issue Jun 9, 2022 · 5 comments
Labels
backlog Queued in backlog enhancement New feature or request

Comments

@christian-konrad
Copy link
Contributor

christian-konrad commented Jun 9, 2022

Is your feature request related to a problem? Please describe

Developers are building extensions for the properties panel that are disparate from the regular properties panel feature set. One and probably the best example is at Camunda, we are integrating the comments panel in the Web Modeler next to the properties panel. As there is no way to embed it into the properties panel itself, users are switching between the properties and comments with tabs outside of the properties panel, in a way that does not look and feel great. It violates some UX hierarchy principles. Additionally, the panel header is kind-of repeated, because the context of the selected flow node is also relevant for the comments tab (and all other tabs/panels people are building).

Describe the solution you'd like

A way to mount both the header and body of the panel separately (optionally), so consumers can build their own navigation patterns around or in between it.

Example illustration to demonstrate it:

PanelTabs

Describe alternatives you've considered

  • A way to hide the panel header completely, but then it must be reimplemented by the surrounding/embedding tool (i.e. the Web Modeler)
  • Deferred idea: Introduce tabs into the properties panel (again), but only as an extension point, so I as a developer can mount my extensions into the panel by providing the extension and a tab title. If I do not provide this, no tabs will appear at all (it then stays the same as before).

Additional context

@christian-konrad christian-konrad added the enhancement New feature or request label Jun 9, 2022
@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Jun 9, 2022

We removed tabs via the new properties panel architecture. The goal now should be that we bring them back?

Context: Blog post (Section "The new properties panel")

Would it be an option to have the comments as a separate group?

@nikku
Copy link
Member

nikku commented Jun 9, 2022

👍 on @pinussilvestrus comment.

One thing I could imagine is to be able to consume header and properties panel body as separate components; this way users, i.e. Web Modeler can implement arbitrary tabbing (I do understand the need to have the header on top of everything else).

@nikku nikku added the help wanted Extra attention is needed label Jun 9, 2022
@christian-konrad
Copy link
Contributor Author

@nikku I can also imagine this. I add your thought to the alternatives section (even if I would say, I would prefer your alternative for now). If it solves the problem for the Web Modeler, totally fine. How could it look like for our panel consumers to mount both parts individually from an API point of view?
Is it a concern of performance/syncing both header and content?
I think it also works for others adding their own disparate stuff to the right section of the screen and allowing them to build their own experience around switching the views (I've seen a lot of different solutions where this happened and it just looked "off" due to double header or missing header).

@nikku
Copy link
Member

nikku commented Jun 10, 2022

How could it look like for our panel consumers to mount both parts individually from an API point of view?

Would need to look into it and so could anyone else on the team. Moving to ready.

@nikku nikku added ready Ready to be worked on needs discussion Needs further discussion and removed help wanted Extra attention is needed labels Jun 10, 2022
@MaxTru
Copy link
Contributor

MaxTru commented Jun 21, 2022

No capacity in this iteration. Moving to backlog for now.

@MaxTru MaxTru added the backlog Queued in backlog label Jun 21, 2022 — with bpmn-io-tasks
@MaxTru MaxTru removed the ready Ready to be worked on label Jun 21, 2022
@christian-konrad christian-konrad changed the title Tabs for the properties panel as a extension point Header and body seperately renderable Jul 5, 2022
@christian-konrad christian-konrad removed the needs discussion Needs further discussion label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants