Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle case when WSGIHeaderDict has None in values #1453

Closed
wants to merge 1 commit into from
Closed

handle case when WSGIHeaderDict has None in values #1453

wants to merge 1 commit into from

Conversation

Andrey-mp
Copy link

if key has None value then .get(key) throws an Exception

fixes #1452

@Andrey-mp
nadle case when WSGIHeaderDict has None in values
3eb5ea9 
if key has None value then .get(key) throws an Exception

fixes bottlepy#1452
@Andrey-mp Andrey-mp changed the title nadle case when WSGIHeaderDict has None in values handle case when WSGIHeaderDict has None in values Sep 10, 2024
@defnull defnull mentioned this pull request Sep 10, 2024
Open
@defnull
Copy link
Member

defnull commented Sep 11, 2024

As discussed in the issue, None is not a valid value type for a WSGI header, it should never appear in environ and never be returned as a header value from Bottle. Crashing is the correct behavior if the environ does not meet expectations.

@defnull defnull closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WSGIHeaderDict fails to get item if it's present and None in original dict
2 participants
@Andrey-mp @defnull