Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53 fix_route53_ids handler can result in confusing error #3033

Open
tim-finnigan opened this issue Oct 5, 2023 · 0 comments
Open

Route53 fix_route53_ids handler can result in confusing error #3033

tim-finnigan opened this issue Oct 5, 2023 · 0 comments
Labels
bug This issue is a confirmed bug. confusing-error p3 This is a minor priority issue

Comments

@tim-finnigan
Copy link
Contributor

tim-finnigan commented Oct 5, 2023

Describe the bug

The fix_route53_ids handler for Route53 commands could result in the following error:
AttributeError: 'NoneType' object has no attribute 'split'

See #3025 for more context, specifically #3025 (comment):

...When my manage domains operation creates a certificate validation resource record, it stores the associated DNS name and value in a DynamoDB table as a string set. When a request is made to delete the domain, it pulls the certificate validation DNS details from the DynamoDB table. Since the string set data type doesn't preserve the original order (my mistake for using a string set instead of a list), the DNS name and value parameters are coming back in a different order than how I originally inserted them. Thus when the change_resource_record_sets method is called, the name and value parameters are transposed so the method can't find record set that it is being asked to delete.

And therein lies the bug in botocore. I should be getting some sort of "resource record not found" error returned to the invalid request but instead, it returns the very unhelpful 'NoneType' object has no attribute 'split' error. This seems like a logic error to me. The fix_route53_ids method is being called prior to verifying the resource record's existence.

@tim-finnigan tim-finnigan added bug This issue is a confirmed bug. confusing-error p3 This is a minor priority issue labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a confirmed bug. confusing-error p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

1 participant