Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 #383

Open
ex0ns opened this issue Mar 29, 2024 · 0 comments
Open

Scala 3 #383

ex0ns opened this issue Mar 29, 2024 · 0 comments

Comments

@ex0ns
Copy link
Contributor

ex0ns commented Mar 29, 2024

I did not notice that the lib was not published for scala 3 and that is a shame (I have been using scala 3 since it's out), I have a WIP branch (scala3) that remove jHttp (keep it for the 2.X users), however I will have to find a replacement for circe-generic-extras:

circe/circe-generic-extras#168

I was considering using jsoniter-scala however I think that have circe without the extras is something that should be less breaking for the lib and I think I will go forward with that.

The "good news" is that circe.generic.extras seems to be used only in ./core/src/com/bot4s/telegram/marshalling/CirceEncoders and in a few other places (where it can be easily replaced). However I don't have a lot of bandwidth now and I don't know when I will be able to tackle this. Feel free to contribute to the scala3 branch if you want.

https://github.com/circe/circe/blob/v0.14.6/modules/tests/shared/src/test/scala-3/io/circe/ConfiguredDerivesSuite.scala#L197
https://github.com/circe/circe/blob/v0.14.6/modules/core/shared/src/main/scala-3/io/circe/derivation/ConfiguredCodec.scala

I think we want to avoid duplicating this file, so maybe we should have a simple helper for scala2/scala3 that returns a codec for a given type, I don't know how feasible that is but that would be the quickest way to get up and running

Edit:
we could use https://github.com/VirtuslabRnD/scalafix-migrate-circe-generic-extras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant