Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not return Collection and List will no longer be allowed #206

Merged

Conversation

Oddant1
Copy link
Contributor

@Oddant1 Oddant1 commented Sep 17, 2024

Closes #205

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (2562a9a) to head (820aa64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   98.56%   98.00%   -0.56%     
==========================================
  Files          85      155      +70     
  Lines        4872     9684    +4812     
  Branches        0      423     +423     
==========================================
+ Hits         4802     9491    +4689     
- Misses         70      140      +70     
- Partials        0       53      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Oddant1, thanks for the fix - looks good to me! Unless you need this open for anything, I'll merge 🚀

@Oddant1
Copy link
Contributor Author

Oddant1 commented Sep 18, 2024

@misialq you are good to merge it. There is a corresponding framework PR as well that we will merge after this.

@misialq misialq merged commit 7154897 into bokulich-lab:main Sep 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: collate_kraken2_outputs returns list
2 participants