Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: parallelize Kaiju classification #200

Merged
merged 11 commits into from
Oct 3, 2024

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Aug 30, 2024

Closes #199.

QIIME docs on how to use the parallelization can be found here.

To run you'll need any artifact with short reads and a Kaiju DB which can be fetched using the fetch-kaiju-db action.

Depends on #201.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (a6e3a4d) to head (e93b5e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   98.73%   97.73%   -1.01%     
==========================================
  Files          78       64      -14     
  Lines        4671     4715      +44     
  Branches        0      391     +391     
==========================================
- Hits         4612     4608       -4     
+ Misses         59       58       -1     
- Partials        0       49      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the dependent label Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

This PR/issue depends on:

@misialq misialq marked this pull request as ready for review September 2, 2024 13:41
@misialq misialq requested review from a team and VinzentRisch and removed request for a team September 2, 2024 13:41
Copy link
Contributor

@ChristosMatzoros ChristosMatzoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

q2_moshpit/plugin_setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@VinzentRisch VinzentRisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!
I ran it on euler with the plasmids db and paired reads with parsl and it works without any problems.

@misialq misialq merged commit 428fcae into bokulich-lab:main Oct 3, 2024
8 of 10 checks passed
@misialq misialq deleted the parallelize-kaiju branch October 3, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: parallelize classification with Kaiju
3 participants