Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise POST for validating manifest rather than GET #9

Open
chrxr opened this issue Aug 15, 2016 · 5 comments
Open

Utilise POST for validating manifest rather than GET #9

chrxr opened this issue Aug 15, 2016 · 5 comments

Comments

@chrxr
Copy link
Collaborator

chrxr commented Aug 15, 2016

Hi @schwemmer,

@calvinbutcher has had a pull request accepted to the IIIF validator, so it should now accept POST requests. Please could the manifest editor utilise this rather than GET via a 3rd party.

IIIF/presentation-validator#25

Note: route for POST is actually just /validate, not /postvalidate.

Thanks,
Chris

@schwemmer
Copy link
Collaborator

Hi Chris,

Great, directly POSTing to the validator is certainly the better option, now that this is possible. There are a couple of minor issues that I need to sort out. I will comment on the validator Github repo (getting a CORS error and don't know how to specify the API version and what the POST parameter for the manifest data is).

@chrxr
Copy link
Collaborator Author

chrxr commented Aug 15, 2016

Also, thinking about it, they may not have deployed the changes yet. The POST parameter should be "json".

https://github.com/IIIF/presentation-api/blob/master/implementations/validator/validator.py#L72

@schwemmer
Copy link
Collaborator

Yes, that's it. Thanks!

@schwemmer
Copy link
Collaborator

See also this issue: IIIF/presentation-validator#22

@schwemmer
Copy link
Collaborator

schwemmer commented Jun 11, 2017

The issue with POSTing to the IIIF Presentation API validator has been resolved (cf. IIIF/presentation-validator#22). However, there now is a server configuration issue which prevents a large portion of the tested manifests to be validated successfully via POST because of "Error 413: Request Entity Too Large" (cf. IIIF/presentation-validator#53).

Before this is fixed, we should not merge the changes to master.

schwemmer added a commit that referenced this issue Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants