Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after_failure not works as expected #522

Open
inkvizitor68sl opened this issue Jun 4, 2021 · 0 comments
Open

after_failure not works as expected #522

inkvizitor68sl opened this issue Jun 4, 2021 · 0 comments

Comments

@inkvizitor68sl
Copy link
Contributor

inkvizitor68sl commented Jun 4, 2021

Hi.

In docs/ABSTRUSE_YML.md we can find information about after_success/after_failure sections for .abstruse.yml
But currently after_failure not works as described:

  1. If "script" part was successfull abstruse run both of after_success/after_failure:
Hello world
==> /bin/true
==> ci-helpers success_mail
==> ci-helpers failed_mail

Exit code: 0
  1. If script failed - none of them will be executed:
Hello world
==> /bin/false

Exit code: 1
==> rpc error: code = Unknown desc = errored: 1

Probably because of this - https://github.com/bleenco/abstruse/blob/master/server/parser/parser.go#L191
Looks like all yaml sections (before_script/script/after_success/after_failure) mixed here to one structure and they executing just one by one until something failed without separate logic for after_failure.

Sorry, not powered in golang to make patch example for that =(

@inkvizitor68sl inkvizitor68sl changed the title after_success/after_failure not works now after_failure not works as expected Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant