Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools need better feedback to prevent double-clicking #61

Open
jenschr opened this issue May 9, 2019 · 5 comments
Open

Tools need better feedback to prevent double-clicking #61

jenschr opened this issue May 9, 2019 · 5 comments
Assignees

Comments

@jenschr
Copy link
Member

jenschr commented May 9, 2019

Windows users tend to double-click, so they checkin and out within less than a second. Adding red color to the button of checked out tools will make it very visible if a tool is checked out.

@jonnor
Copy link
Contributor

jonnor commented May 9, 2019

If people double clicking is the problem, why would a visual warning fix this? They won't have time to see it?

Or are they supposed to notice the flash after doing it wrong one time, then not do it wrong the next time?

@jenschr
Copy link
Member Author

jenschr commented May 9, 2019

Well... As they can see other tools be checked out as red color, they'll hopefully notice that theirs didn't go red? I'm very open to other alternatives. I had a go at disabling the button briefly, but the problem is that Angular is using two physical buttons (toggling between these), so disabling the clicked button won't have any effect.

@trygvis
Copy link
Contributor

trygvis commented May 10, 2019

Hm, I'm pretty sure Angular only uses a single button and that disabling the button until the request comes back should work.

@jenschr
Copy link
Member Author

jenschr commented May 10, 2019

Angular uses a single button, but if you look through this code - we are using multiple buttons to implement conditional logic.

@jenschr
Copy link
Member Author

jenschr commented May 10, 2019

Anyway - I think PR #62 solves this without complex button interaction. Would be great if we could just try that one out. This issue/PR was created to solve one of the most common questions we get from users. Just highlighting the buttons for tools that are checked out could be enough, so great if you guys can just approve the PR after checking that I did nothing wrong.

tingox added a commit that referenced this issue Jun 3, 2019
Fix for #61: make it easy to see that a tool is checked out
clehre added a commit to clehre/p2k16 that referenced this issue Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants