-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools need better feedback to prevent double-clicking #61
Comments
If people double clicking is the problem, why would a visual warning fix this? They won't have time to see it? Or are they supposed to notice the flash after doing it wrong one time, then not do it wrong the next time? |
Well... As they can see other tools be checked out as red color, they'll hopefully notice that theirs didn't go red? I'm very open to other alternatives. I had a go at disabling the button briefly, but the problem is that Angular is using two physical buttons (toggling between these), so disabling the clicked button won't have any effect. |
Hm, I'm pretty sure Angular only uses a single button and that disabling the button until the request comes back should work. |
Angular uses a single button, but if you look through this code - we are using multiple buttons to implement conditional logic. |
Anyway - I think PR #62 solves this without complex button interaction. Would be great if we could just try that one out. This issue/PR was created to solve one of the most common questions we get from users. Just highlighting the buttons for tools that are checked out could be enough, so great if you guys can just approve the PR after checking that I did nothing wrong. |
Fix for #61: make it easy to see that a tool is checked out
Windows users tend to double-click, so they checkin and out within less than a second. Adding red color to the button of checked out tools will make it very visible if a tool is checked out.
The text was updated successfully, but these errors were encountered: