Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #105

Open
trygvis opened this issue Aug 13, 2021 · 1 comment
Open

Upgrade dependencies #105

trygvis opened this issue Aug 13, 2021 · 1 comment

Comments

@trygvis
Copy link
Contributor

trygvis commented Aug 13, 2021

The dependencies really needs a bump, but both SQLAlchemy and Flask have breaking changes from new major versions. This needs to be reviews/fully tested, but there are also some stale libraries that we depend on.

Misc related issues:

  • SQLAlchemy 1.4 compatibility kvesteri/sqlalchemy-continuum#255
  • Flask-SQLAlchemy seems to only support Flask v1 in their 3.0 version, but that has not been released yet. However, I couldn't find any particular reason why Flask-SQLAlchemy wouldn't work from the changelog.
  • flask-bower seems stale and doesn't work because flask._compat is gone. Seems easy to fix the module itself, but it probably needs a fork+fix or maybe we can just rewrite something custom.
@trygvis
Copy link
Contributor Author

trygvis commented Aug 31, 2021

It would be nice to drop the recent workarounds for missing auto-detection of http vs https when using flask.url_for() with this: https://werkzeug.palletsprojects.com/en/2.0.x/middleware/proxy_fix/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant