Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Recap References for Year-in-review newsletter formats #1198

Open
bitschmidty opened this issue Jul 12, 2023 · 3 comments
Open
Assignees

Comments

@bitschmidty
Copy link
Contributor

I should have tested for the year in review formatting when the original recap auto-references PR was opened, my bad 🙋

In creating the 231 year-in-review recap, I ran into some issues. It seems the featured summaries sections are not handled correctly by the recap references generator

see PR here: #1197
a local preview here:
Screen Shot 2023-07-12 at 10 23 50 AM

  • improvement to support handling the "featured summaries" in year in review (https://bitcoinops.org/en/newsletters/2022/12/21/)
  • nice to have: linking "within" a month for the subtopics in that month. Although I think the month-only timestamps is fine
@bitschmidty bitschmidty self-assigned this Jul 12, 2023
@harding
Copy link
Collaborator

harding commented Jul 13, 2023

Obviously, please feel free to make any changes to the year-in-review formatting to accommodate the recap stuff. For example, to encapsulate stuff in HTML5 <section> tags or to use a hidden header like:

{:.hidden}
### Fee sponsorship

@kouloumos
Copy link
Contributor

I'll get to this soon.

@bitschmidty
Copy link
Contributor Author

@kouloumos I figured out a few formatting tweaks that work with the current architecture for YiR 2023, news/pod282.

#1449

So I think we are good here. I just need to apply those to YiR 2022, news/pod231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants